Skip to content

[ci] Migrated CI to github #105#106

Merged
nemesifier merged 2 commits intomasterfrom
github-ci
Apr 14, 2021
Merged

[ci] Migrated CI to github #105#106
nemesifier merged 2 commits intomasterfrom
github-ci

Conversation

@ManishShah120
Copy link
Copy Markdown
Contributor

closes #105

@ManishShah120 ManishShah120 force-pushed the github-ci branch 4 times, most recently from cee5bf8 to 0f15335 Compare April 10, 2021 13:34
Comment thread .github/workflows/ci.yml Outdated
@ManishShah120 ManishShah120 self-assigned this Apr 10, 2021
@ManishShah120 ManishShah120 requested a review from purhan April 12, 2021 04:45
@ManishShah120
Copy link
Copy Markdown
Contributor Author

Hello @pandafy can you please look into this.

Copy link
Copy Markdown
Member

@pandafy pandafy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor improvements requested, but rest looks good.

Comment thread .github/workflows/ci.yml Outdated
Comment thread requirements-test.txt Outdated
Copy link
Copy Markdown
Member

@pandafy pandafy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
Deferring merge to @nemesisdesign

@nemesifier nemesifier merged commit 3c34047 into master Apr 14, 2021
@nemesifier nemesifier deleted the github-ci branch April 14, 2021 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[ci] Migrate network topology to github actions

4 participants